CodeQL findings — Svc/Ccsds/CfdpManager/Types

devel @ e84571354780 · generated 2026-09-03T21:21:21Z
FileLineRuleSeverityMessage
Svc/Ccsds/CfdpManager/Types/NakPdu.cpp:163163cpp/fprime/division-guardmediumThe divisor segmentSize is not checked against zero before this / operation.
Svc/Ccsds/CfdpManager/Types/NakPdu.hpp:7575cpp/fprime/checking-parameter-valuesmediumParameter index is used as an array index or divisor without first being checked (e.g. with FW_ASSERT or a condition).
Svc/Ccsds/CfdpManager/Types/Tlv.cpp:2121cpp/fprime/jpl-c/checking-return-valuesmediumThe return value of non-void function [memset](1) is not checked.
Svc/Ccsds/CfdpManager/Types/Tlv.cpp:3535cpp/fprime/jpl-c/checking-return-valuesmediumThe return value of non-void function [memcpy](1) is not checked.
Svc/Ccsds/CfdpManager/Types/Tlv.cpp:149149cpp/fprime/jpl-c/checking-return-valuesmediumThe return value of non-void function [memset](1) is not checked.
Svc/Ccsds/CfdpManager/Types/AckPdu.cpp:1414cpp/fprime/jpl-c/use-of-assertions-densitylowAll functions of more than 10 lines should have at least one assertion, unless they handle errors by returning a status enum or bool, or by emitting a WARNING/FATAL event.
Svc/Ccsds/CfdpManager/Types/AckPdu.cpp:1414cpp/jpl-c/function-size-limitslowinitialize has too many parameters (9, while 6 are allowed).
Svc/Ccsds/CfdpManager/Types/AckPdu.cpp:104104cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/AckPdu.cpp:117117cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/EofPdu.cpp:1414cpp/fprime/jpl-c/use-of-assertions-densitylowAll functions of more than 10 lines should have at least one assertion, unless they handle errors by returning a status enum or bool, or by emitting a WARNING/FATAL event.
Svc/Ccsds/CfdpManager/Types/EofPdu.cpp:1414cpp/jpl-c/function-size-limitslowinitialize has too many parameters (8, while 6 are allowed).
Svc/Ccsds/CfdpManager/Types/FileDataPdu.cpp:1515cpp/fprime/jpl-c/use-of-assertions-densitylowAll functions of more than 10 lines should have at least one assertion, unless they handle errors by returning a status enum or bool, or by emitting a WARNING/FATAL event.
Svc/Ccsds/CfdpManager/Types/FileDataPdu.cpp:1515cpp/jpl-c/function-size-limitslowinitialize has too many parameters (8, while 6 are allowed).
Svc/Ccsds/CfdpManager/Types/FinPdu.cpp:1414cpp/fprime/jpl-c/use-of-assertions-densitylowAll functions of more than 10 lines should have at least one assertion, unless they handle errors by returning a status enum or bool, or by emitting a WARNING/FATAL event.
Svc/Ccsds/CfdpManager/Types/FinPdu.cpp:1414cpp/jpl-c/function-size-limitslowinitialize has too many parameters (8, while 6 are allowed).
Svc/Ccsds/CfdpManager/Types/FinPdu.cpp:108108cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/FinPdu.cpp:109109cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/MetadataPdu.cpp:1616cpp/jpl-c/function-size-limitslowinitialize has too many parameters (10, while 6 are allowed).
Svc/Ccsds/CfdpManager/Types/MetadataPdu.cpp:9494cpp/jpl-c/function-size-limitslowtoSerialBuffer has too many lines (73, while 60 are allowed).
Svc/Ccsds/CfdpManager/Types/MetadataPdu.cpp:123123cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/MetadataPdu.cpp:168168cpp/jpl-c/function-size-limitslowfromSerialBuffer has too many lines (80, while 60 are allowed).
Svc/Ccsds/CfdpManager/Types/NakPdu.cpp:1414cpp/fprime/jpl-c/use-of-assertions-densitylowAll functions of more than 10 lines should have at least one assertion, unless they handle errors by returning a status enum or bool, or by emitting a WARNING/FATAL event.
Svc/Ccsds/CfdpManager/Types/NakPdu.cpp:1414cpp/jpl-c/function-size-limitslowinitialize has too many parameters (7, while 6 are allowed).
Svc/Ccsds/CfdpManager/Types/NakPdu.hpp:3636cpp/fprime/magic-numberslowMagic number 58; consider a named constant (enum, static constexpr, or #define).
Svc/Ccsds/CfdpManager/Types/PduBase.hpp:8888cpp/jpl-c/includes-firstlow'#include <Svc/Ccsds/CfdpManager/Types/AckPdu.hpp>' is preceded by code -- it should be moved above line 24 in PduBase.hpp.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:1616cpp/fprime/jpl-c/use-of-assertions-densitylowAll functions of more than 10 lines should have at least one assertion, unless they handle errors by returning a status enum or bool, or by emitting a WARNING/FATAL event.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:6464cpp/fprime/jpl-c/use-of-assertions-densitylowAll functions of more than 10 lines should have at least one assertion, unless they handle errors by returning a status enum or bool, or by emitting a WARNING/FATAL event.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:9595cpp/jpl-c/function-size-limitslowtoSerialBuffer has too many lines (67, while 60 are allowed).
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:110110cpp/fprime/magic-numberslowMagic number 5; consider a named constant (enum, static constexpr, or #define).
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:110110cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:111111cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:112112cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:113113cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:114114cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:134134cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:135135cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:136136cpp/jpl-c/compound-expressionslowThis expression involving bitwise operations should be bracketed.
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:163163cpp/jpl-c/function-size-limitslowfromSerialBuffer has too many lines (66, while 60 are allowed).
Svc/Ccsds/CfdpManager/Types/PduHeader.cpp:173173cpp/fprime/magic-numberslowMagic number 5; consider a named constant (enum, static constexpr, or #define).
Svc/Ccsds/CfdpManager/Types/Types.hpp:421421cpp/jpl-c/hidden-pointer-indirection-typedeflowThe typedef CfdpTraverseAllTransactionsFunc hides pointer indirection.